[CLI-1431] Add non-root user to Dockerfile so users don't have to run as root with container#1388
Merged
David Hyde (DABH) merged 1 commit intomainfrom Aug 13, 2022
Merged
[CLI-1431] Add non-root user to Dockerfile so users don't have to run as root with container#1388David Hyde (DABH) merged 1 commit intomainfrom
David Hyde (DABH) merged 1 commit intomainfrom
Conversation
David Hyde (DABH)
changed the title
Steven Gagniere (sgagniere)
approved these changes
Aug 9, 2022
| RUN adduser \ | ||
| --disabled-password \ | ||
| --gecos "" \ | ||
| --ingroup "$USER" \ |
There was a problem hiding this comment.
Would we be able to drop the double quotes on this line and lines 17 & 18, since the environment variables do not have any spaces or patterns? If so, we could match the style on line 8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixed a small gotcha that would have broken the release process on M1 Macs (forcing the Dockerfile to use alpine/amd64 instead of allowing alpine/arm64).