[FF-7973] CLI should not require user-login to produce/consume using an API key#1390
Merged
Kevin Wu (kevin-wu24) merged 1 commit intomainfrom Aug 11, 2022
Merged
[FF-7973] CLI should not require user-login to produce/consume using an API key#1390Kevin Wu (kevin-wu24) merged 1 commit intomainfrom
Kevin Wu (kevin-wu24) merged 1 commit intomainfrom
Conversation
David Hyde (DABH)
approved these changes
Aug 8, 2022
Contributor
David Hyde (DABH)
left a comment
David Hyde (DABH)
left a comment
There was a problem hiding this comment.
A comment in here about why this check is here (and maybe a comment about the subsequent if block too?) would be useful. If other people have to read this code in the future, I could see them being confused :)
Thank you!
Contributor
|
(Oh, and see why Mac CI fails??) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
yes
What
Fixed bug preventing producing/consuming from cluster when using an API key/secret by adding an additional check for an anonymous cluster being used in a context, as the check below it only sees if the config file has been updated less than a week ago.
References
https://confluentinc.atlassian.net/browse/FF-7973
Test & Review