String content and var style updates#1393
Merged
Steven Gagniere (sgagniere) merged 18 commits intomainfrom Aug 10, 2022
Merged
Conversation
…alization and full stops to match guidelines in README.md
…ErrorMsg since they were used as errors, and moved a non-error message from error_message.go to strings.go
…ted the README guidelines
…od, and modified the README guidelines to reflect this
… semicolon and removed capitalization/fullstop
…he style of the rest of the strings
David Hyde (DABH)
approved these changes
Aug 9, 2022
Contributor
David Hyde (DABH)
left a comment
There was a problem hiding this comment.
Looks good, thanks for the cleanup! ✨
| @@ -1 +1 @@ | |||
| Error: Audit Logs are not enabled for this organization. | |||
| Error: Audit Logs are not enabled for this organization | |||
Contributor
There was a problem hiding this comment.
Why did this one lose a period but the one below gained a period? (Conservation laws aside...)
Member
Author
There was a problem hiding this comment.
This one's an error, so it doesn't have an ending period. The next one (assuming it's describe-invalid-role-cloud.golden is a suggestion, so I added one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
Various changes to strings in
internal/pkg/errors/strings.goandinternal/pkg/errors/error_message.go(and affected files):ErrorMsgsuffix to some error string variables which were missing it, and modified the suffix of some strings being used as error messages fromMsgtoErrorMsg.SuggestiontoSuggestionsto match the README guidelines (even when the suggestion consists of a single sentence).Msgfromerror_messages.gotostrings.go.References
N/A
Test & Review
Ran
make test.