added commands for consumer crud and redeem workflow by stkr89 · Pull Request #1395 · confluentinc/cli

Sumit Tokkar (stkr89) · 2022-08-10T15:35:05Z

Checklist

[CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?
- yes: ok
- no: DO NOT MERGE until the required functionalites are live in prod

What

Added CLI commands for consumer share crud and redeem workflow

References

CLI commands for Stream Sharing

Test & Review

Added integration tests

…and-resend-email-invite

internal/cmd/stream-share/command_consumer_redeem.go

internal/cmd/stream-share/command_consumer_share.go

internal/pkg/errors/strings.go

test/test-server/streamsharing_handler.go

…email-invite' of github.com:confluentinc/cli into stokkar/CDX-401-add-cli-commands-for-create-and-resend-email-invite

…and-resend-email-invite # Conflicts: # internal/cmd/stream-share/command.go # internal/cmd/stream-share/command_provider.go # internal/cmd/stream-share/command_provider_share.go # internal/cmd/stream-share/command_provider_share_delete.go # internal/cmd/stream-share/command_provider_share_describe.go # internal/cmd/stream-share/command_provider_share_list.go # internal/pkg/ccloudv2/stream-share.go

internal/cmd/stream-share/command_consumer_redeem.go

internal/cmd/stream-share/command_provider_invite_create.go

internal/cmd/stream-share/command_provider_invite_resend.go

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

…and-resend-email-invite # Conflicts: # test/test-server/ccloudv2_router.go

test/test-server/ccloudv2_router.go

internal/cmd/stream-share/command_consumer_redeem.go

internal/cmd/stream-share/command_consumer_share.go

internal/cmd/stream-share/command_consumer_share_list.go

internal/cmd/stream-share/command_provider.go

internal/pkg/ccloudv2/stream-share.go

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

…-for-create-and-resend-email-invite' into stokkar/CDX-401-add-cli-commands-for-create-and-resend-email-invite

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

…-for-create-and-resend-email-invite' into stokkar/CDX-401-add-cli-commands-for-create-and-resend-email-invite

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

…-for-create-and-resend-email-invite' into stokkar/CDX-401-add-cli-commands-for-create-and-resend-email-invite

internal/cmd/stream-share/command_consumer_redeem.go

internal/cmd/stream-share/command_provider_invite_create.go

internal/cmd/stream-share/command_provider_share.go

internal/pkg/ccloudv2/stream-share.go

test/test-server/ccloudv2_router.go

Sumit Tokkar (stkr89) added 2 commits August 10, 2022 10:03

added commands for consumer crud and redeem workflow

a3dfe01

code refactor

502ad2a

Sumit Tokkar (stkr89) requested a review from Brian Strauch (brianstrauch) August 10, 2022 15:35

Sumit Tokkar (stkr89) requested a review from a team as a code owner August 10, 2022 15:35

code refactor

e74d752

Sumit Tokkar (stkr89) requested a review from Alex Cheng (atxalex8) August 10, 2022 15:38

Merge branch 'main' into stokkar/CDX-401-add-cli-commands-for-create-…

94447b9

…and-resend-email-invite

Brian Strauch (brianstrauch) reviewed Aug 15, 2022

View reviewed changes

Sumit Tokkar (stkr89) marked this pull request as draft August 15, 2022 22:06

Sumit Tokkar (stkr89) added 6 commits August 16, 2022 10:05

code refactor

088cf4b

updates as per PR comments

9cdc41c

fixed test cases

2defe80

Merge branch 'stokkar/CDX-401-add-cli-commands-for-create-and-resend-…

372da97

…email-invite' of github.com:confluentinc/cli into stokkar/CDX-401-add-cli-commands-for-create-and-resend-email-invite

renamed method names

6db5787

Sumit Tokkar (stkr89) marked this pull request as ready for review August 16, 2022 20:26

Sumit Tokkar (stkr89) requested a review from Brian Strauch (brianstrauch) August 16, 2022 20:26

Brian Strauch (brianstrauch) reviewed Aug 16, 2022

View reviewed changes

Sumit Tokkar (stkr89) and others added 12 commits August 17, 2022 09:16

Update internal/cmd/stream-share/command_consumer_redeem.go

8a1296c

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Update internal/cmd/stream-share/command_consumer_redeem.go

1f6bfde

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Update internal/cmd/stream-share/command_consumer_share.go

0de33a4

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Update internal/cmd/stream-share/command_consumer_share.go

979e90a

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Update internal/cmd/stream-share/command_consumer_share_list.go

1862a9d

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Update internal/cmd/stream-share/command_provider_invite.go

c45090d

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Update internal/cmd/stream-share/command_provider_invite_create.go

dda0130

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Update internal/cmd/stream-share/command_provider_invite_create.go

0397b92

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Update internal/cmd/stream-share/command_provider_invite_resend.go

55a8aca

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Update internal/cmd/stream-share/command_provider_invite_resend.go

c0fff91

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

fixes as per PR comments

7d5e363

renamed methods and updated test cases

ce9c283

Sumit Tokkar (stkr89) requested a review from Brian Strauch (brianstrauch) August 17, 2022 16:01

Sumit Tokkar (stkr89) added 4 commits August 17, 2022 14:13

Merge branch 'main' into stokkar/CDX-401-add-cli-commands-for-create-…

217b177

…and-resend-email-invite # Conflicts: # test/test-server/ccloudv2_router.go

include group in redeem share

3513957

updated test case

9604995

mark environment and cluster as required fields

5013bd2

Brian Strauch (brianstrauch) reviewed Aug 17, 2022

View reviewed changes

Sumit Tokkar (stkr89) and others added 10 commits August 17, 2022 15:39

Update internal/cmd/stream-share/command_consumer_redeem.go

7df6f14

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Update internal/cmd/stream-share/command_consumer_share_list.go

cd42fa8

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Update internal/cmd/stream-share/command_provider.go

0635c14

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

added error handling

486a491

Merge remote-tracking branch 'origin/stokkar/CDX-401-add-cli-commands…

66a75d7

…-for-create-and-resend-email-invite' into stokkar/CDX-401-add-cli-commands-for-create-and-resend-email-invite

Update internal/cmd/stream-share/command_consumer_redeem.go

032eded

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Merge remote-tracking branch 'origin/stokkar/CDX-401-add-cli-commands…

c81a802

…-for-create-and-resend-email-invite' into stokkar/CDX-401-add-cli-commands-for-create-and-resend-email-invite

Update internal/cmd/stream-share/command_consumer_share.go

d566714

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Merge remote-tracking branch 'origin/stokkar/CDX-401-add-cli-commands…

e06141d

…-for-create-and-resend-email-invite' into stokkar/CDX-401-add-cli-commands-for-create-and-resend-email-invite

updated method names and field names

6f9f5c9

Sumit Tokkar (stkr89) requested a review from Brian Strauch (brianstrauch) August 17, 2022 21:30

renamed invite expires at field

9199b78

Brian Strauch (brianstrauch) reviewed Aug 18, 2022

View reviewed changes

Sumit Tokkar (stkr89) added 2 commits August 18, 2022 14:07

renamed fields and use generic flags for env and cluster

fd03cb6

sort handlers

6beba63

Sumit Tokkar (stkr89) requested a review from Brian Strauch (brianstrauch) August 18, 2022 19:13

Brian Strauch (brianstrauch) approved these changes Aug 18, 2022

View reviewed changes

Sumit Tokkar (stkr89) merged commit 315f76e into main Aug 18, 2022

Sumit Tokkar (stkr89) deleted the stokkar/CDX-401-add-cli-commands-for-create-and-resend-email-invite branch August 18, 2022 20:24

Conversation

Sumit Tokkar (stkr89) commented Aug 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

What

References

Test & Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sumit Tokkar (stkr89) commented Aug 10, 2022 •

edited

Loading