Cluster describe cleanup#1397
Merged
Steven Gagniere (sgagniere) merged 2 commits intomainfrom Aug 12, 2022
Merged
Conversation
David Hyde (DABH)
approved these changes
Aug 11, 2022
Contributor
David Hyde (DABH)
left a comment
David Hyde (DABH)
left a comment
There was a problem hiding this comment.
Added test coverage = ❤️
Thanks for the cleanup! ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
Removed some redundant code in
command_cluster_describe.gothat I noticed while working on a ticket. Since the terminal output is controlled by the fields string slice input tooutput.DescribeObject, I collapsed two structs which differed by only 1 field into a combined struct and removed the functionconvertClusterToDescribeStructWithKAPIsince its implementation was identical toconvertClusterToDescribeStruct.Also added 2 new integration tests to also check the json and yaml output of
kafka cluster describe lkc-id --all.References
N/A
Test & Review
Ran all tests.
Manually checked on a basic cluster that the output of
kafka cluster describe lkc-id --all,kafka cluster describe lkc-id --all -o jsonandkafka cluster describe lkc-id --all -o yamldid not change.