[CLI-1776, RCCA-8029] Add --unsafe-trace flag#1400
Merged
Brian Strauch (brianstrauch) merged 7 commits intomainfrom Aug 18, 2022
Merged
[CLI-1776, RCCA-8029] Add --unsafe-trace flag#1400Brian Strauch (brianstrauch) merged 7 commits intomainfrom
--unsafe-trace flag#1400Brian Strauch (brianstrauch) merged 7 commits intomainfrom
Conversation
Brian Strauch (brianstrauch)
requested review from
Kostya Linou (linouk23) and
Mukul Khullar - Confluent (mkcops)
Brian Strauch (brianstrauch)
changed the title
--unsafe-trace flag--unsafe-trace flag
David Hyde (DABH)
suggested changes
Aug 17, 2022
Contributor
David Hyde (DABH)
left a comment
David Hyde (DABH)
left a comment
There was a problem hiding this comment.
A couple questions on this one
David Hyde (DABH)
approved these changes
Aug 18, 2022
Contributor
David Hyde (DABH)
left a comment
David Hyde (DABH)
left a comment
There was a problem hiding this comment.
Ok up to comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
Add a new global flag,
--unsafe-trace, which prints trace logs to the terminal (equivalent to-vvvv) and debug-level output from ccloud-sdk-go-v2 and retryablehttp, which both could print secrets.Additionally,
-vvvand-vvvvno longer print potentially insecure HTTP request/response information, which is a breaking change. Since this is a fix for a SEV-2, it's OK to make this breaking change.Also made a few small refactors to
ccloudv2.NewClient().References
Discussion: https://confluent.slack.com/archives/C03Q5LDR4TG/p1658438531342239
Test & Review
Unit tests, integration tests, manual testing