added extra check to verify that the cluster is running before deleting the topics#1418
Merged
Luca Filipponi (luca-filipponi) merged 5 commits intomainfrom Sep 6, 2022
Conversation
Luca Filipponi (luca-filipponi)
requested a review
from a team
as a code owner
Co-authored-by: Brian Strauch <bstrauch@confluent.io>
…github.com:confluentinc/cli into feature/KFS-181_delete_cluster_provisioning_failed
Luca Filipponi (luca-filipponi)
requested review from
Steven Zhang (stevenpyzhang) and
Tomasz Nguyen (swist)
Co-authored-by: Brian Strauch <bstrauch@confluent.io>
Tomasz Nguyen (swist)
approved these changes
Aug 30, 2022
Brian Strauch (brianstrauch)
approved these changes
Aug 30, 2022
Luca Filipponi (luca-filipponi)
deleted the
feature/KFS-181_delete_cluster_provisioning_failed
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
Deleting ksql clusters that failed to provision was returning an error. This was happening because cluster deletion is trying to delete ksql internal topic by calling an enpoint on the ksql itself. If the cluster is not provisioned this request was failing and the cluster was not deleted
References
https://confluentinc.atlassian.net/browse/KFS-181
Test & Review
Build the cli locally