Stream Designer CLI Initial Setup#1436
Merged
Brian Strauch (brianstrauch) merged 45 commits intomainfrom Oct 3, 2022
Merged
Conversation
Author
|
Reopened PR from different branch so here were the comments from Xin Xiang (@xiangxin72) thanks sgaddam-confluent for the PR this makes me feel that maybe involving cli-eng, even for this internal dev_branch preparation would be useful (for which you can cut a branch stream-designer-cli from master, and put your change in to stream-designer-cli-sgaddam branch and open an PR against stream-designer-cli). I feel they may give more effective suggestions than us, on things like: 1) how to centralize stream_designer client SDK (instead of creating http client repetitively), and / or 2) whether the constructor for each command is following the recommended practice. |
Brian Strauch (brianstrauch)
suggested changes
Sep 14, 2022
Xin Xiang (xiangxin72)
force-pushed
the
stream-designer-cli-sgaddam
branch
from
4469011 to
53ba4f5
Compare
sgaddam-confluent
force-pushed
the
stream-designer-cli-sgaddam
branch
from
f05bb89 to
8eb248a
Compare
sgaddam-confluent
force-pushed
the
stream-designer-cli-sgaddam
branch
3 times, most recently
from
eebfbf4 to
35bf116
Compare
sgaddam-confluent
force-pushed
the
stream-designer-cli-sgaddam
branch
from
35bf116 to
3d226c9
Compare
Xin Xiang (xiangxin72)
changed the base branch from
stream-designer-cli
to
main
Brian Strauch (brianstrauch)
approved these changes
Oct 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
CLI for Stream Designer
PR for initial feedback and test CLI locally
References
https://confluentinc.atlassian.net/browse/SD-36
Test & Review
Pending manual testing - follow setup guide here
Review stakeholders
Context: Design Note