restore license line in goreleaser files#1456
Merged
Steven Gagniere (sgagniere) merged 1 commit intomainfrom Oct 10, 2022
Merged
restore license line in goreleaser files#1456Steven Gagniere (sgagniere) merged 1 commit intomainfrom
Steven Gagniere (sgagniere) merged 1 commit intomainfrom
Conversation
David Hyde (DABH)
approved these changes
Oct 8, 2022
Contributor
David Hyde (DABH)
left a comment
David Hyde (DABH)
left a comment
There was a problem hiding this comment.
ok once CI passes on Windows 😕
Brian Strauch (brianstrauch)
suggested changes
Oct 10, 2022
Brian Strauch (brianstrauch)
left a comment
Brian Strauch (brianstrauch)
left a comment
There was a problem hiding this comment.
The LICENSE file doesn't get created anymore, so it won't get added. Do we necessarily need it?
Member
Author
It's not a generated file, it's committed to the repo. |
Brian Strauch (brianstrauch)
approved these changes
Oct 10, 2022
Brian Strauch (brianstrauch)
left a comment
Brian Strauch (brianstrauch)
left a comment
There was a problem hiding this comment.
Didn't realize what this was for, oops!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
Restore bundling of the LICENSE file in the archives built by the goreleaser files
References
Test & Review
Built the glibc versions, unzipped one of the tar.gz files and confirmed that the LICENSE file is there