Linux build update#1460
Merged
Steven Gagniere (sgagniere) merged 26 commits intomainfrom Dec 10, 2022
Merged
Conversation
…libc arm64 bin/archive from amd64 machines
…n't build the windows binary
…building on an m1
Co-authored-by: Brian Strauch <bstrauch@confluent.io>
… linux-build-update
Co-authored-by: Brian Strauch <bstrauch@confluent.io>
… linux-build-update
Co-authored-by: Brian Strauch <bstrauch@confluent.io>
Co-authored-by: Brian Strauch <bstrauch@confluent.io>
… linux-build-update
Co-authored-by: Brian Strauch <bstrauch@confluent.io>
Brian Strauch (brianstrauch)
approved these changes
Dec 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
Changed the base image for building the Linux glibc arm64 binary/archive on amd64 laptops. The current version builds inside of an arm64 CentOS 7 image using emulation, which is very slow. The new version builds inside of an amd64 Ubuntu Bionic image using a arm64 cross compiler, reducing build time to around 70 to 80 seconds, down from 12+ minutes.
A few notes:
build_linux_glibc.shandrelease.mkhave been added to instead use an arm64-based image to build the arm64 binary/archive, so that M1 laptops only have to emulate to build the amd64 binary/archive.The image changes are:
amd64 laptops:
cli-centos-base-amd64tocli-centos-base-amd64:2.0(2.0removesgolicense, which we aren't using anymore and wasn't used in this build anyway)cli-centos-base-arm64tocli-ubuntu-base-arm64:latestarm64 laptops:
cli-centos-base-arm64tocli-ubuntu-base-arm64:m1(if/whendocker manifestmakes it out of experimental, we can revisit this and roll both images into the same tag to simplify this)Also did a bit of cleanup: removed windows override in the glibc goreleaser files and removed the S3FOLDER variable from the
gorelease-linux-glibctargets since both are unused in the build.References
N/A
Test & Review
Checked that the binaries built in the new images run in the current images (glibc compatibility check) and that the produce/consume commands work