Skip to content

[CLI-2030] hide kafka quota, pool, provider, stream-share cmds when feature flag not enabled#1461

Merged
MuweiHe merged 5 commits intomainfrom
CLI-2030
Oct 12, 2022
Merged

[CLI-2030] hide kafka quota, pool, provider, stream-share cmds when feature flag not enabled#1461
MuweiHe merged 5 commits intomainfrom
CLI-2030

Conversation

@MuweiHe
Copy link
Contributor

@MuweiHe MuweiHe commented Oct 11, 2022

Checklist

  1. [CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?
    • yes: ok

What

Users caught that they are still able to run confluent iam provider list (with or without an error) even though the flag is not enabled and hid from its parent command. see: https://confluentinc.atlassian.net/browse/RCCA-9133.This pr makes those feature flag controlled commands not executable when not available.

// when not enabled
mhe@C02DV0KVMD6T cli % confluent ss
Error: unknown command "ss" for "confluent"
Run 'confluent --help' for usage.

// when enabled
mhe@C02DV0KVMD6T cli % confluent ss
Manage stream shares.

Usage:
  confluent stream-share [command]

Aliases:
  stream-share, ss

Available Commands:
  consumer    Manage consumer actions.
  provider    Manage provider actions.

References

Test & Review

@MuweiHe MuweiHe marked this pull request as ready for review October 11, 2022 02:11
@MuweiHe MuweiHe requested a review from a team as a code owner October 11, 2022 02:11
Co-authored-by: Brian Strauch <bstrauch@confluent.io>
@MuweiHe MuweiHe merged commit b636d67 into main Oct 12, 2022
@MuweiHe MuweiHe deleted the CLI-2030 branch October 12, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants