Goreleaser update

[Steven Gagniere (sgagniere)]

Checklist

1. [CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?
   N/A

What

Newer versions of goreleaser append a GOAMD64 microarchitecture value to the build directory name in dist for amd64 builds. The default is _v1, which is the same microarchitecture as builds using older versions. This convention change causes Windows and Darwin signing/notarization to fail because the paths to the binaries are hardcoded into the .goreleaser.yml and gon_confluent_amd64.hcl files.

This PR updates the signing lines to account for this.

• For Windows, the hardcoded relative path in the post hook is replaced with {{ .Path }}, which is a goreleaser variable available to the hook storing the absolute path to the binary.
• For Darwin, the file path must be provided in an .hcl file. Since modifying the .hcl directly results in a dirty repo, a post hook makes a copy inside the dist folder (which is in .gitignore) and another post hook calls the new gon_filepath_editor.sh script which uses {{ .Path }} to update the copy.
  • I could not get the sed command to work directly in a post hook; that's why I made it into a script
• I also made this change for the Darwin arm64 signing.

The reason for using {{ .Path }} instead of hardcoding the new convention (and for modifying the arm64 signing even though the folder name hasn't changed) is because the Goreleaser docs note that there is no guarantee that conventions will not change in future versions. So we remove all assumptions on what the naming convention is.

Test & Review

• Ranrelease-to-stag
• Downloaded the .exe and .zip (and extracted from the zip) from S3 staging folder & github release and checked that they're all signed correctly with .osslsigncode verify path/to/binary
• Likewise checked that the amd64 Darwin binaries are signed correctly with codesign -dv --verbose=4 path/to/binary

[MuweiHe]

Thanks! We shouldve fixed those hardcoded paths long ago... There're also a lot of hardcoded paths in release targets too (like coping stuff from local to s3) that we can follow up as well.

[Brian Strauch (brianstrauch)]

Can we put all of the gon files in a scripts/ directory? There's a lot of them now and I think that's the best place for them... https://github.com/golang-standards/project-layout#scripts

[Steven Gagniere (sgagniere)]

Sure. I can also move the new sh file and the build_linux_glibc file in there too

[Steven Gagniere (sgagniere)]

Also, I just realized... by removing the hardcoded path from the gon files, they're now identical. So I can replace them with one.

[Steven Gagniere (sgagniere)]

Forgot to mention: this change is to add redundancy in the case where goreleaser errors out before it can run the post-hook to remove this file.

[Brian Strauch (brianstrauch)]

Let's only remove this if it exists then?

[Brian Strauch (brianstrauch)]

Alternatively, we could add the file to .gitignore and the make clean target, just in case it doesn't get cleaned up automatically.

[Steven Gagniere (sgagniere)]

The -f flag removes it if it exists and does nothing w/o error if it doesn't.

I think this is enough. It should always be removed now unless the process is stopped with ctrl+c.

[Brian Strauch (brianstrauch)]

cool, didn't know about -f!