Resolve issue causing missing endpoints in cluster config#1470
Merged
Steven Gagniere (sgagniere) merged 3 commits intomainfrom Oct 18, 2022
Merged
Resolve issue causing missing endpoints in cluster config#1470Steven Gagniere (sgagniere) merged 3 commits intomainfrom
Steven Gagniere (sgagniere) merged 3 commits intomainfrom
Conversation
David Hyde (DABH)
approved these changes
Oct 18, 2022
Contributor
David Hyde (DABH)
left a comment
There was a problem hiding this comment.
+1 once CI passes!
Brian Strauch (brianstrauch)
approved these changes
Oct 18, 2022
| KafkaClusterContext: &v1.KafkaClusterContext{ | ||
| KafkaClusterConfigs: map[string]*v1.KafkaClusterConfig{ | ||
| "lkc-123456": {LastUpdate: update}, | ||
| "lkc-123456": {LastUpdate: update, Bootstrap: "test"}, |
There was a problem hiding this comment.
Want to use a more realistic value here?
Member
Author
There was a problem hiding this comment.
How about this new version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
Calling
FindKafkaClusterindynamic_context.gobefore the cluster has finished provisioning causes the cluster info to be saved inconfig.jsonwithbootstrap_serversequal to""and noapi_endpointorrest_endpoint. As the config is only updated after at least one week since the timestamp saved inconfig.json, this prevents use of the cluster unless the timestamp is manually changed to trick the CLI into thinking it should be updated.Found by calling
kafka cluster describeon a provisioning cluster; this command now uses kafka REST for one of the description fields. Other commands using kafka REST also create this issue, e.g.kafka topiccommands.This PR makes a single change: if the config is not
nilandBootstrapis the empty string, then refresh the config.References
n/a
Test & Review
Tested by calling
kafka cluster describeon a provisioning cluster, and then again after it finished provisioning to check that it now prints the description as expected.Open questions / Follow ups
Follow ups:
kafka cluster describeto not check for topics while thestatusisPROVISIONINGand instead print an empty value. This command still errors out at the moment.