[CLI-1954] Allow users with no role bindings to log in#1478
Merged
Brian Strauch (brianstrauch) merged 2 commits intomainfrom Oct 25, 2022
Merged
[CLI-1954] Allow users with no role bindings to log in#1478Brian Strauch (brianstrauch) merged 2 commits intomainfrom
Brian Strauch (brianstrauch) merged 2 commits intomainfrom
Conversation
Brian Strauch (brianstrauch)
requested a review
from Steven Gagniere (sgagniere)
Steven Gagniere (sgagniere)
approved these changes
Oct 25, 2022
| switch credType { | ||
| case Username: | ||
| return c.State != nil && c.State.AuthToken != "" && c.State.Auth != nil && c.State.Auth.Account != nil && c.State.Auth.Account.Id != "" | ||
| return c.GetAuthToken() != "" && c.GetEnvironment().GetId() != "" |
There was a problem hiding this comment.
Significant readability improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
When a user is invited to an organization, they initially have 0 role-bindings (no access). They aren't allowed to view the list of environments, so their list of environments is
[]on login. Previously the CLI would error with "not logged in", but this PR allows these users to log in, replicating the behavior of the UI. Bonus: Refactored a few lines to prevent nil pointer errors.References
https://confluentinc.atlassian.net/browse/CLI-1954
Test & Review
Manual verification, all tests still pass.