[CLI-1497, CLI-2037] Replace sync.WaitGroup with chan#1483
Merged
Brian Strauch (brianstrauch) merged 2 commits intomainfrom Oct 26, 2022
Merged
[CLI-1497, CLI-2037] Replace sync.WaitGroup with chan#1483Brian Strauch (brianstrauch) merged 2 commits intomainfrom
sync.WaitGroup with chan#1483Brian Strauch (brianstrauch) merged 2 commits intomainfrom
Conversation
added 2 commits
October 26, 2022 10:41
Steven Gagniere (sgagniere)
approved these changes
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
sync.WaitGroupwill panic when decremented twice simultaneously. This happened to two customers (that we know of) and can happen when someone takes exactly 30s to log in, or auto-login takes exactly 30s.References
CLI-1497
CLI-2037