[CLI-744] verify cluster existence in confluent cluster unregister to avoid false success message#1485
Merged
Brian Strauch (brianstrauch) merged 4 commits intomainfrom Oct 27, 2022
Merged
Conversation
| return err | ||
| } | ||
|
|
||
| response, err := c.MDSClient.ClusterRegistryApi.DeleteNamedCluster(ctx, name) |
There was a problem hiding this comment.
Can we open a ticket with the security team to make this API return an error if the cluster doesn't exist? This shouldn't have to be a CLI change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
MDS client doesn't return error when trying to unregister a non-exist cluster. add a verification before that and return error if no such cluster name is found.
References
https://confluentinc.atlassian.net/browse/CLI-744
Test & Review