[CLI-190, CLI-1940] In kafka topic create, remove defaults for num partitions and replication factor#1487
Merged
Brian Strauch (brianstrauch) merged 2 commits intomainfrom Oct 28, 2022
Merged
Conversation
David Hyde (DABH)
approved these changes
Oct 27, 2022
Contributor
David Hyde (DABH)
left a comment
David Hyde (DABH)
left a comment
There was a problem hiding this comment.
LGTM assuming Kafka team confirms!
This was referenced Nov 9, 2022
Brian Strauch (brianstrauch)
changed the title
kafka topic create, remove defaults for num partitions and replication factorkafka topic create, remove defaults for num partitions and replication factor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
The backend will set these values automatically now. Verified that
num.partitions = 6, but the replication factor is read-only, so checking with the Kafka team that it defaults to 3 before merging.