List (KsqlAdmin) role bindings for user not showing the Logical ksql clusterId#1522
Merged
Brian Strauch (brianstrauch) merged 7 commits intomainfrom Nov 17, 2022
Merged
List (KsqlAdmin) role bindings for user not showing the Logical ksql clusterId#1522Brian Strauch (brianstrauch) merged 7 commits intomainfrom
Brian Strauch (brianstrauch) merged 7 commits intomainfrom
Conversation
|
Panagiotis (Panos) Garefalakis (@pgaref) This PR looks good, but it's untested. Can you add an integration test to |
Contributor
Author
Yes, working on this as we speak! Thanks! |
test/fixtures/output/iam/rbac/role-binding/list-user-6-cloud.golden
Outdated
Show resolved
Hide resolved
MuweiHe
reviewed
Nov 16, 2022
Brian Strauch (brianstrauch)
suggested changes
Nov 17, 2022
Brian Strauch (brianstrauch)
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
https://confluentinc.atlassian.net/browse/KSQL-9550
List role bindings for user not showing the Logical ksql cluster id to differentiate.
Added an extra List call to get pksqlid, output changed from:
to:
Note: ksqlDB_cluster_0 is delete thus does not have a pksqlc anymore (this should not happen in practice as we automatically cleanup role binding when a Ksql cluster is being deleted)
References
Test & Review