Skip to content

DOCS-18824: Add Embedded Kafka REST command#1541

Merged
Tikiela Mims (tikimims) merged 2 commits intomainfrom
tikimims/DOCS-18824
Nov 28, 2022
Merged

DOCS-18824: Add Embedded Kafka REST command#1541
Tikiela Mims (tikimims) merged 2 commits intomainfrom
tikimims/DOCS-18824

Conversation

@tikimims
Copy link
Contributor

Checklist

  1. [CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?
    • yes: ok
    • no: DO NOT MERGE until the required functionalites are live in prod

What

References

Test & Review

RunE: c.onPremCreate,
Example: examples.BuildExampleString(
examples.Example{
Text: "Create a topic named `my_topic` with default options at specified cluster (providing embedded Kafka REST Proxy endpoint).",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the example under this one too? Resources should be surrounded with quotes, not backticks!

Suggested change
Text: "Create a topic named `my_topic` with default options at specified cluster (providing embedded Kafka REST Proxy endpoint).",
Text: `Create a topic named "my_topic" with default options for the current cluster (providing embedded Kafka REST Proxy endpoint).`,

Copy link
Contributor Author

@tikimims Tikiela Mims (tikimims) Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2022-11-22 at 6 13 39 PM

Hi Brian Strauch (@brianstrauch) Thanks for taking a look. Looks like there are other examples formatted that way too. I will add a note to the JIRA to update this at the same time as I go through them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay updated Brian Strauch (@brianstrauch) 👍 Does everything else look okay?

@tikimims Tikiela Mims (tikimims) changed the title [WIP/DRAFT] DOCS-18824: Add Embedded Kafka REST command DOCS-18824: Add Embedded Kafka REST command Nov 28, 2022
@tikimims Tikiela Mims (tikimims) marked this pull request as ready for review November 28, 2022 18:50
@tikimims Tikiela Mims (tikimims) requested a review from a team as a code owner November 28, 2022 18:50
@tikimims
Copy link
Contributor Author

Brian Strauch (@brianstrauch) Double checking, okay if I go ahead and merge this one?

@brianstrauch

Brian Strauch (@brianstrauch) Double checking, okay if I go ahead and merge this one?

Tikiela Mims (@tikimims) Yes, thank you!

@tikimims
Copy link
Contributor Author

Okay great! Thanks Brian Strauch (@brianstrauch) 👍

@tikimims Tikiela Mims (tikimims) merged commit a3736a2 into main Nov 28, 2022
@tikimims Tikiela Mims (tikimims) deleted the tikimims/DOCS-18824 branch November 28, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants