[SD-1631] Add activation privilege to update command#1645
Merged
Brian Strauch (brianstrauch) merged 10 commits intomainfrom Jan 12, 2023
Merged
[SD-1631] Add activation privilege to update command#1645Brian Strauch (brianstrauch) merged 10 commits intomainfrom
Brian Strauch (brianstrauch) merged 10 commits intomainfrom
Conversation
Xin Xiang (xiangxin72)
requested review from
a team and
Brian Strauch (brianstrauch)
Brian Strauch (brianstrauch)
left a comment
Brian Strauch (brianstrauch)
left a comment
There was a problem hiding this comment.
In the future, we'll hopefully have RBAC roles that will allow users to accomplish the same thing with confluent iam rbac role-binding create. But until then, this looks good.
Brian Strauch (brianstrauch)
changed the title
Xin Xiang (xiangxin72)
changed the title
Xin Xiang (xiangxin72)
changed the title
MuweiHe
reviewed
Jan 12, 2023
MuweiHe
reviewed
Jan 12, 2023
Contributor
Author
|
thanks Brian Strauch (@brianstrauch) for the feedback, a local test shows this worked fine to grant/revoke privileges. Can you take another pass? Not sure this can make today's release |
Brian Strauch (brianstrauch)
approved these changes
Jan 12, 2023
added 5 commits
January 12, 2023 14:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
Allow
updatecommand to accept a--activation-privilegeparameter, for user to specify whether to grant or revoke the activation privileges.This parameter is already supported at server side
References
Test & Review