[CLI-3479] Union of Pools Identity Provider #3065
Merged
Cynthia Qin (cqin-confluent) merged 11 commits intomainfrom Mar 31, 2025
Merged
[CLI-3479] Union of Pools Identity Provider #3065Cynthia Qin (cqin-confluent) merged 11 commits intomainfrom
Cynthia Qin (cqin-confluent) merged 11 commits intomainfrom
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for an "identity-claim" flag to the identity provider CLI commands for updating, creating, and listing identity providers.
- Introduces the "identity-claim" flag in update, create, and list commands.
- Updates the output structure to display the identity claim.
- Adjusts required flags for the update command.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/iam/command_provider_update.go | Adds the "identity-claim" flag and updates flag requirements. |
| internal/iam/command_provider_list.go | Displays the identity claim in the list output. |
| internal/iam/command_provider_create.go | Adds the "identity-claim" flag and includes it in the creation payload. |
| internal/iam/command_provider.go | Extends the identity provider output struct with IdentityClaim. |
Comments suppressed due to low confidence (1)
internal/iam/command_provider_create.go:66
- [nitpick] In the create command, the identity claim is always set on the payload even when an empty string is provided. Consider conditionally setting IdentityClaim (similar to the update command) to avoid unintentionally overwriting a default value when no identity claim is intended.
IdentityClaim: identityproviderv2.PtrString(identityClaim),
Member
|
Was the existing case where the |
tmalik (tmalikconfluent)
approved these changes
Mar 29, 2025
Daniel Ayaz (danielayaz)
approved these changes
Mar 31, 2025
Steven Gagniere (sgagniere)
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
Breaking Changes
New Features
--identity-claimflag toconfluent iam providerBug Fixes
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Add optional
--identity-claimflag to IAM provider creation/update command that enables user to specify a JSON Web Token (JWT) claim for providers. This is for Confluent Cloud resource.Blast Radius
None. This is an additive change, so no existing commands should be affected.
References
Feature Request 1-Pager
Product Design 1-Pager
Test & Review
Test and Verification Doc