[CLI-3544] Only set consumer.interceptor.classes and producer.interceptor.classes for Confluent Platform 7.9 or lower#3086
Merged
Steven Gagniere (sgagniere) merged 1 commit intomainfrom May 1, 2025
Conversation
…s for 7.9.x or lower
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the behavior of the CLI so that the monitoring interceptor configuration options are only set for services running on Confluent Platform 7.9 or lower (i.e. in Zookeeper mode).
- Adds an extra condition to ensure interceptor configs are only applied in Zookeeper mode.
- Updates the conditional in getConfig for services such as connect, kafka-rest, ksql-server, and schema-registry.
Comments suppressed due to low confidence (1)
internal/local/command_services.go:470
- [nitpick] Consider extracting the overall condition into a well-named boolean variable (e.g. shouldSetInterceptors) to improve readability.
if isCP && slices.Contains([]string{"connect", "kafka-rest", "ksql-server", "schema-registry"}, service) && zookeeperMode {
Channing Dong (channingdong)
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
Breaking Changes
New Features
Bug Fixes
confluent local servicesno longer setsconsumer.interceptor.classesandproducer.interceptor.classesconfiguration options by default when used with Confluent Platform 8.0Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
For Confluent Platform.
These configs rely on a jar file that ships with Control Center, so we need to remove these configs when running with 8.0 (but keep them when running in 7.9 or lower).
Since we're using ZK for 7.9 or lower and KRaft for 8.0 and above, this PR implements this change by only setting these configs when running in ZK mode.
Blast Radius
This change is applied to the following local services: connect, kafka rest, ksql, and schema registry.
Blast radius should be minimal since these configuration options are optional.
References
Test & Review
Test results: https://docs.google.com/document/d/1ROkpDEMn_jcmLmnHFQ9dW6OvmS4cm9oV0a2W70JlunY/edit?usp=sharing