Skip to content

[INC-2165] Add support for PRIVATE_NETWORK_INTERFACE#3109

Merged
tmalik (tmalikconfluent) merged 1 commit intomainfrom
INC-2165
May 21, 2025
Merged

[INC-2165] Add support for PRIVATE_NETWORK_INTERFACE#3109
tmalik (tmalikconfluent) merged 1 commit intomainfrom
INC-2165

Conversation

@tmalikconfluent
Copy link
Contributor

@tmalikconfluent tmalik (tmalikconfluent) commented May 21, 2025

Release Notes

Breaking Changes

  • PLACEHOLDER

New Features

  • PLACEHOLDER

Bug Fixes

  • Support PRIVATE_NETWORK_INTERFACE network type for confluent kafka region list command

Checklist

  • I have successfully built and used a custom CLI binary, without linter issues from this PR.
  • I have clearly specified in the What section below whether this PR applies to Confluent Cloud, Confluent Platform, or both.
  • I have verified this PR in Confluent Cloud pre-prod or production environment, if applicable.
  • I have verified this PR in Confluent Platform on-premises environment, if applicable.
  • I have attached manual CLI verification results or screenshots in the Test & Review section below.
  • I have added appropriate CLI integration or unit tests for any new or updated commands and functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Confluent Platform
    • Check this box if the feature is enabled for certain organizations only

What

Error was being thrown when we run kafka region list command due to unknown value "PRIVATE_NETWORK_INTERFACE" for enum ccloud.scheduler.NetworkType. Fixed the issue.

Blast Radius

None

References

https://confluentinc.atlassian.net/browse/INC-2165
confluentinc/ccloud-sdk-go-v1-public#43

Test & Review

Screenshot 2025-05-16 at 4 51 46 PM

Copilot AI review requested due to automatic review settings May 21, 2025 22:58
@tmalikconfluent tmalik (tmalikconfluent) requested a review from a team as a code owner May 21, 2025 22:58
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Confluent Cloud SDK dependency to pull in support for the PRIVATE_NETWORK_INTERFACE network type.

  • Bumps ccloud-sdk-go-v1-public to a version that includes the new enum value.
  • (Implicit) Regenerates any API clients or code that rely on the updated SDK.
Comments suppressed due to low confidence (2)

go.mod:17

  • Add or update unit tests to verify that the new PRIVATE_NETWORK_INTERFACE network type is correctly handled in relevant commands (e.g., kafka region list).
github.com/confluentinc/ccloud-sdk-go-v1-public v0.0.0-20250521223017-0e8f6f971b52

go.mod:17

  • Run go mod tidy to ensure your go.sum is updated and that there are no unused dependencies after bumping the SDK version.
github.com/confluentinc/ccloud-sdk-go-v1-public v0.0.0-20250521223017-0e8f6f971b52

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please update the release note to mention the command (and remove the period at the end).

@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (76.90% Estimated after merge)
  • Duplications No duplication information (0.00% Estimated after merge)

Project ID: cli

View in SonarQube

@tmalikconfluent tmalik (tmalikconfluent) merged commit 912ba88 into main May 21, 2025
3 checks passed
@tmalikconfluent tmalik (tmalikconfluent) deleted the INC-2165 branch May 21, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants