[INC-2165] Add support for PRIVATE_NETWORK_INTERFACE#3109
Merged
tmalik (tmalikconfluent) merged 1 commit intomainfrom May 21, 2025
Merged
[INC-2165] Add support for PRIVATE_NETWORK_INTERFACE#3109tmalik (tmalikconfluent) merged 1 commit intomainfrom
tmalik (tmalikconfluent) merged 1 commit intomainfrom
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Confluent Cloud SDK dependency to pull in support for the PRIVATE_NETWORK_INTERFACE network type.
- Bumps
ccloud-sdk-go-v1-publicto a version that includes the new enum value. - (Implicit) Regenerates any API clients or code that rely on the updated SDK.
Comments suppressed due to low confidence (2)
go.mod:17
- Add or update unit tests to verify that the new PRIVATE_NETWORK_INTERFACE network type is correctly handled in relevant commands (e.g.,
kafka region list).
github.com/confluentinc/ccloud-sdk-go-v1-public v0.0.0-20250521223017-0e8f6f971b52
go.mod:17
- Run
go mod tidyto ensure yourgo.sumis updated and that there are no unused dependencies after bumping the SDK version.
github.com/confluentinc/ccloud-sdk-go-v1-public v0.0.0-20250521223017-0e8f6f971b52
Steven Gagniere (sgagniere)
approved these changes
May 21, 2025
Member
Steven Gagniere (sgagniere)
left a comment
There was a problem hiding this comment.
Thanks!
Please update the release note to mention the command (and remove the period at the end).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
Breaking Changes
New Features
Bug Fixes
PRIVATE_NETWORK_INTERFACEnetwork type forconfluent kafka region listcommandChecklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Error was being thrown when we run
kafka region listcommand due to unknown value "PRIVATE_NETWORK_INTERFACE" for enum ccloud.scheduler.NetworkType. Fixed the issue.Blast Radius
None
References
https://confluentinc.atlassian.net/browse/INC-2165
confluentinc/ccloud-sdk-go-v1-public#43
Test & Review