-
Notifications
You must be signed in to change notification settings - Fork 20
[APIE-483] Support for Azure Tableflow #3190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall!
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Azure Data Lake Storage Gen2 (ADLS) as a storage option for Confluent tableflow topics, alongside the existing BYOS (AWS S3) and MANAGED storage types.
Key Changes:
- Integration with Azure ADLS through new command-line flags and storage configuration
- Migration from public SDK (
ccloud-sdk-go-v2) to internal SDK (ccloud-sdk-go-v2-internal) - Comprehensive test coverage for Azure tableflow operations (enable, describe, list, update, disable, delete)
Reviewed Changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
go.mod |
Updated Go version and added internal SDK dependency |
pkg/ccloudv2/client.go |
Migrated tableflow import from public to internal SDK |
pkg/ccloudv2/tableflow.go |
Updated tableflow SDK import path |
internal/tableflow/command_topic.go |
Added Azure storage type constant and output fields for Azure-specific properties |
internal/tableflow/command_topic_enable.go |
Added Azure storage support with new flags (storage-account-name, container-name) |
internal/tableflow/command_topic_list.go |
Added Azure-specific field extraction in list command |
internal/tableflow/command_catalog_integration*.go |
Updated SDK import paths to internal version |
test/test-server/tableflow_handlers.go |
Added test handlers for Azure tableflow topic operations |
test/tableflow_test.go |
Added integration tests for Azure tableflow commands |
test/fixtures/output/tableflow/topic/*.golden |
Added expected output fixtures for Azure tableflow operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
8a84c37 to
4a2985a
Compare
|




Release Notes
Breaking Changes
New Features
confluent tableflow [create | list]commandsBug Fixes
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Add support for azure tableflow.
Blast Radius
Could affect tableflow enable, describe and list commands in the worst case scenario.
References
https://confluentinc.atlassian.net/browse/APIE-483
Test & Review
Added extensive integration tests.
Manual Testing

Enable:
List:

Describe:

Update:

Disable:

More details: https://docs.google.com/document/d/1gWD28MWFty83njQLjIY6Gqp886iQPPJZa2VbJZP-3vo/edit?tab=t.0