Skip to content

Conversation

@tmalikconfluent
Copy link
Contributor

@tmalikconfluent tmalikconfluent commented Sep 24, 2025

Release Notes

Breaking Changes

  • PLACEHOLDER

New Features

  • Add Azure support for the confluent tableflow [create | list] commands

Bug Fixes

  • PLACEHOLDER

Checklist

  • I have successfully built and used a custom CLI binary, without linter issues from this PR.
  • I have clearly specified in the What section below whether this PR applies to Confluent Cloud, Confluent Platform, or both.
  • I have verified this PR in Confluent Cloud pre-prod or production environment, if applicable.
  • I have verified this PR in Confluent Platform on-premises environment, if applicable.
  • I have attached manual CLI verification results or screenshots in the Test & Review section below.
  • I have added appropriate CLI integration or unit tests for any new or updated commands and functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Confluent Platform
    • Check this box if the feature is enabled for certain organizations only

What

Add support for azure tableflow.

Blast Radius

Could affect tableflow enable, describe and list commands in the worst case scenario.

References

https://confluentinc.atlassian.net/browse/APIE-483

Test & Review

Added extensive integration tests.

Manual Testing
Enable:
image

List:
image

Describe:
image

Update:
image

Disable:
image

More details: https://docs.google.com/document/d/1gWD28MWFty83njQLjIY6Gqp886iQPPJZa2VbJZP-3vo/edit?tab=t.0

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@sonarqube-confluent

This comment has been minimized.

Copy link
Member

@cqin-confluent cqin-confluent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall!

@sonarqube-confluent

This comment has been minimized.

2 similar comments
@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent
Copy link

Passed

Analysis Details

2 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 2 Code Smells

Coverage and Duplications

  • Coverage 91.40% Coverage (78.20% Estimated after merge)
  • Duplications No duplication information (0.10% Estimated after merge)

Project ID: cli

View in SonarQube

@tmalikconfluent tmalikconfluent marked this pull request as ready for review October 16, 2025 17:23
@tmalikconfluent tmalikconfluent requested a review from a team as a code owner October 16, 2025 17:23
Copilot AI review requested due to automatic review settings October 16, 2025 17:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Azure Data Lake Storage Gen2 (ADLS) as a storage option for Confluent tableflow topics, alongside the existing BYOS (AWS S3) and MANAGED storage types.

Key Changes:

  • Integration with Azure ADLS through new command-line flags and storage configuration
  • Migration from public SDK (ccloud-sdk-go-v2) to internal SDK (ccloud-sdk-go-v2-internal)
  • Comprehensive test coverage for Azure tableflow operations (enable, describe, list, update, disable, delete)

Reviewed Changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
go.mod Updated Go version and added internal SDK dependency
pkg/ccloudv2/client.go Migrated tableflow import from public to internal SDK
pkg/ccloudv2/tableflow.go Updated tableflow SDK import path
internal/tableflow/command_topic.go Added Azure storage type constant and output fields for Azure-specific properties
internal/tableflow/command_topic_enable.go Added Azure storage support with new flags (storage-account-name, container-name)
internal/tableflow/command_topic_list.go Added Azure-specific field extraction in list command
internal/tableflow/command_catalog_integration*.go Updated SDK import paths to internal version
test/test-server/tableflow_handlers.go Added test handlers for Azure tableflow topic operations
test/tableflow_test.go Added integration tests for Azure tableflow commands
test/fixtures/output/tableflow/topic/*.golden Added expected output fixtures for Azure tableflow operations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqube-confluent
Copy link

@sgagniere sgagniere merged commit 14de7e9 into main Nov 21, 2025
3 checks passed
@sgagniere sgagniere deleted the APIE-483 branch November 21, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants