Bump version to v1.5.0-rc1 #368
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the version from 1.4.1 to 1.5.0-rc1-dev across the project, preparing for a pre-release candidate build.
- Updates version numbers in package.json files and utility module
- Adds version mapping entry in README documentation
- Maintains consistency across all version references in the codebase
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Updates main package version to 1.5.0-rc1-dev |
| schemaregistry/package.json | Updates schema registry package version to 1.5.0-rc1-dev |
| lib/util.js | Updates binding version string to match new version |
| README.md | Adds version mapping entry for 1.5.0 release |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
package.json
Outdated
| { | ||
| "name": "@confluentinc/kafka-javascript", | ||
| "version": "1.4.1", | ||
| "version": "1.5.0-rc1-dev", |
There was a problem hiding this comment.
The version format '1.5.0-rc1-dev' is non-standard. According to semantic versioning, pre-release versions should use '-' for pre-release identifiers but avoid mixing 'rc' and 'dev' suffixes. Consider using either '1.5.0-rc.1' or '1.5.0-dev' format.
| "version": "1.5.0-rc1-dev", | |
| "version": "1.5.0-rc.1", |
schemaregistry/package.json
Outdated
| { | ||
| "name": "@confluentinc/schemaregistry", | ||
| "version": "1.4.1", | ||
| "version": "1.5.0-rc1-dev", |
There was a problem hiding this comment.
The version format '1.5.0-rc1-dev' is non-standard. According to semantic versioning, pre-release versions should use '-' for pre-release identifiers but avoid mixing 'rc' and 'dev' suffixes. Consider using either '1.5.0-rc.1' or '1.5.0-dev' format.
| "version": "1.5.0-rc1-dev", | |
| "version": "1.5.0-rc.1", |
lib/util.js
Outdated
| }; | ||
|
|
||
| util.bindingVersion = '1.4.1'; | ||
| util.bindingVersion = '1.5.0-rc1-dev'; |
There was a problem hiding this comment.
The version format '1.5.0-rc1-dev' is non-standard. According to semantic versioning, pre-release versions should use '-' for pre-release identifiers but avoid mixing 'rc' and 'dev' suffixes. Consider using either '1.5.0-rc.1' or '1.5.0-dev' format.
| util.bindingVersion = '1.5.0-rc1-dev'; | |
| util.bindingVersion = '1.5.0-rc.1'; |
This comment has been minimized.
This comment has been minimized.
Analysis Details0 Issues
Coverage and Duplications
Project ID: confluent-kafka-javascript |
Semaphore run for tag: https://semaphore.ci.confluent.io/workflows/bdb83138-ba3b-4c02-8ff2-631b59f3c4b1?pipeline_id=a32bf0e9-be6c-4bfd-90d0-5904f0d843ab