Made num_partitions optional #1515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahajanadhitya
force-pushed
the
feature/defaultnewtopicparams
branch
from
42f8aa7 to
60d5685
Compare
mahajanadhitya
force-pushed
the
feature/defaultnewtopicparams
branch
from
60d5685 to
5b5ba72
Compare
pranavrth
requested changes
Feb 8, 2023
src/confluent_kafka/src/Admin.c
Outdated
| goto err; | ||
| } | ||
| } | ||
| if (!newt->replica_assignment) { |
There was a problem hiding this comment.
Don't raise this error here. It should be in librdkafka or from the broker.
pranavrth
requested changes
Feb 10, 2023
pranavrth
requested changes
Feb 10, 2023
CHANGELOG.md
Outdated
| SASL PLAIN/SCRAM credentials that will be used for subsequent (new) connections to a broker (#1511). | ||
| - Wheels for Linux / arm64 (#1496). | ||
|
|
||
| - Added support for Default num_partitions(the field is optional now) in CreateTopics Admin API according to KIP-464. |
| } | ||
|
|
||
| if (newt->replica_assignment) { | ||
| if (newt->replication_factor != -1) { |
pranavrth
reviewed
Feb 10, 2023
src/confluent_kafka/src/AdminTypes.c
Outdated
| { "num_partitions", T_INT, offsetof(NewTopic, num_partitions), 0, | ||
| ":py:attribute: Number of partitions (int)" }, | ||
| ":py:attribute: [OPTIONAL] Number of partitions (int).\n" | ||
| "Must be set to -1 or not be provided if a replica_assignment is specified" }, |
There was a problem hiding this comment.
pranavrth
requested changes
Feb 10, 2023
src/confluent_kafka/src/Admin.c
Outdated
| goto err; | ||
| } | ||
|
|
||
| int t; |
There was a problem hiding this comment.
temp_partitions ?
src/confluent_kafka/src/AdminTypes.c
Outdated
| { "num_partitions", T_INT, offsetof(NewTopic, num_partitions), 0, | ||
| ":py:attribute: Number of partitions (int)" }, | ||
| ":py:attribute: Number of partitions (int).\n" | ||
| "Must be set to -1 if a replica_assignment is specified" }, |
There was a problem hiding this comment.
If we are enforcing this, then we don't need this condition.
if (newt->num_partitions == -1) {
t = PyList_Size(newt->replica_assignment);
} else {
t = newt->num_partitions;
}
We can use what's written in Java. In this way, its a suggestion.
The number of partitions for the new topic or -1 if a replica assignment has been specified.
There was a problem hiding this comment.
We are not enforcing to keep backward compatibility, we need the check so prior code does not break.
CHANGELOG.md
Outdated
| SASL PLAIN/SCRAM credentials that will be used for subsequent (new) connections to a broker (#1511). | ||
| - Wheels for Linux / arm64 (#1496). | ||
|
|
||
| - Added support for Default num_partitions(the field is optional now) in CreateTopics Admin API. |
There was a problem hiding this comment.
Remove "(the field is optional now)"
emasab
pushed a commit
that referenced
this pull request
Jun 19, 2023
* Default New Topic Params -> num_partitions optional * Added to Changelog * Keeping one source of truth * Made unit tests and Integration bounded to scope of python client * Changelog * Unit tests removed from Integration test * Flake8 * Review Comments Addressed * flake8 and whitespace changes * Whitespace Changes * flake8 * Whitespaces * Whitespace * PR comment addressal * PR comment addressal * PR comment addressal * PR comment Addressal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.