Skip to content

Conversation

@davidkleiven
Copy link
Contributor

Add | None to arguments in the avro serizlier where the default argument is None

What

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

@davidkleiven davidkleiven requested review from a team as code owners January 8, 2025 13:46
@confluent-cla-assistant
Copy link

confluent-cla-assistant bot commented Jan 8, 2025

🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ davidkleiven
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@davidkleiven davidkleiven force-pushed the fix-type-hint-in-serializers branch from 299bd16 to da8713c Compare January 8, 2025 13:52
@rayokota
Copy link
Member

rayokota commented Jan 8, 2025

/sem-approve

@davidkleiven davidkleiven force-pushed the fix-type-hint-in-serializers branch from da8713c to 22bcafa Compare January 9, 2025 07:19
@rayokota
Copy link
Member

/sem-approve

Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidkleiven , LGTM

@rayokota
Copy link
Member

rayokota commented Jan 13, 2025

@davidkleiven , can you sign the CLA?

@rayokota rayokota merged commit 01fe4dd into confluentinc:master Jan 13, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants