Rename async -> asynchronous arguments (but keep async for now) #21 #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ah-
reviewed
Feb 19, 2018
| if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|OOO", kws, | ||
| &msg, &offsets, &async_o)) | ||
| if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|OOOO", kws, | ||
| &msg, &offsets, &async_o, &async_o)) |
There was a problem hiding this comment.
That's quite nice, does it just overwrite based on which one is set?
Contributor
Author
There was a problem hiding this comment.
Yep, this works since ParseTupleAndKeywords returns borrowed references and does not increase the refcount for each matched object (which wouldn't work here).
Contributor
|
LGTM, assuming there is good enough motivation for the name change in the first place. |
mhowlett
approved these changes
Feb 21, 2018
Contributor
Author
|
Shout out to @johnnoone for the initial PR, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.