Restructure code to be more Pythonic and adhere to PEP8 style #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it looks good and then we look good. :) Otherwise, it's more readable and promotes good practice as many will copy/paste.
|
@confluentinc It looks like @maxzheng just signed our Contributor License Agreement. 👍 Always at your service, clabot |
edenhill
suggested changes
Mar 26, 2018
README.md
Outdated
| print("Message deserialization failed for {}: {}".format(msg, e)) | ||
| break | ||
|
|
||
| if msg: |
There was a problem hiding this comment.
I see that the original code has a bug:
Bool comparison operator calls _msg.len, which is implemented to return the number of bytes of the message value. Tombstone messages however have a null value (but a non-empty key) and thus a len of 0, which will make these messages ignored by this code.
So this should be changed to:
if msg is None:
continue
if msg.error():
...
|
Ping @edenhill |
|
Thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it looks good and then we look good. :) Otherwise, it's more readable and promotes good practice as many will copy/paste.