Fix the MappingProxyType error when converting schema to JSON #930
+8
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@confluentinc It looks like @hoogamaphone just signed our Contributor License Agreement. 👍 Always at your service, clabot |
choogeboom
changed the title
Incognito
approved these changes
Nov 4, 2020
Incognito
left a comment
Incognito
left a comment
There was a problem hiding this comment.
Hey folks, this is an easy way to fix an entire broken feature. Can we get eyes on it?
Author
|
I've given up hope on this PR, and migrated my code to start using |
|
We did this too actually, but it was a shame that my team had to re-work large parts of their work because of it. |
Contributor
https://github.com/apache/avro/blob/master/lang/py3/avro/schema.py#L219 |
mhowlett
reviewed
Mar 11, 2021
Contributor
mhowlett
left a comment
mhowlett
left a comment
There was a problem hiding this comment.
LGTM (hopefully not missing anything important)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avro.schema.Schema.to_jsonusesMappingProxyType, which is not compatible withjson.dumps.This PR solves the issue in the same way that theUnfortunately that was causing appveyor to fail, so I'm just converting to JSON with theavrolibrary solves it, by using theMappingProxyEncoderin theavrolibrary.strfunction, which is the same under the hood.fixes #610