Preps for v1.5.2 release #978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve external meaning .. to docker-compose
…l dir .. rather than the installed module. Should once and for all eliminate the "ImportError: .. confluent_kafka.cimpl" problems.
rnpridgeon
approved these changes
Oct 29, 2020
Contributor
rnpridgeon
left a comment
rnpridgeon
left a comment
There was a problem hiding this comment.
Nit in tox.ini other than that LGTM
| deps = | ||
| {[base]deps} | ||
| avro-python3 | ||
| -rtests/requirements.txt |
Contributor
Author
There was a problem hiding this comment.
That's actually required to be without space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And restructured the source tree to avoid pytest/tox to load confluent-kafka from the source directory rather than what it has installed in its virtual environment.