[rcca-25570] Handle intermediate change of status and add more log lines#305
Merged
Suraj Goel (suraj-goel) merged 1 commit into30.0.1-confluentfrom Feb 13, 2025
Merged
Conversation
| return Response.status(Response.Status.CONFLICT) | ||
| .type(MediaType.TEXT_PLAIN) | ||
| .entity(StringUtils.format("Can't pause, task is not in a pausable state (state: [%s])", status)) | ||
| .entity(StringUtils.format("Can't pause, task is not in a pausable state (state: [%s])", currentStatus)) |
There was a problem hiding this comment.
We can pass in both the current status and the volatile status variable here so that we can directly get it in the task error message on the UI.
Member
Author
There was a problem hiding this comment.
I will raise a followup PR to clean-up extra logs.
will address this as part of that or the upstream fix.
Parth Agrawal (pagrawal10)
approved these changes
Feb 13, 2025
Parth Agrawal (pagrawal10)
left a comment
Parth Agrawal (pagrawal10)
left a comment
There was a problem hiding this comment.
Apart from the minor suggestion on passing both statuses in the error, the changes look good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
internal-metrics-prod, There are occasional failure of a task per day.statusto a local variable and using that to evaluate if statement.Fixed the bug ...
Renamed the class ...
Added a forbidden-apis entry ...
Release note
For tips about how to write a good release note, see Release notes.
Key changed/added classes in this PR
MyFooOurBarTheirBazThis PR has: