[OBSDATA-8872]Add maxInterval to kill config and make kill tasks efficient#309
Merged
Chetan Patidar (chetanpatidar26) merged 2 commits into30.0.1-confluentfrom Mar 27, 2025
Conversation
airlock-confluentinc
Bot
dismissed
Rushikesh Bankar (rbankar7)’s stale review
via
6160b6e
Chetan Patidar (chetanpatidar26)
requested a review
from Rushikesh Bankar (rbankar7)
10 tasks
airlock-confluentinc
Bot
force-pushed
the
max-interval-overrides-durationToRetain
branch
from
6160b6e to
3db97b9
Compare
PANKAJ KUMAR (Pankaj260100)
approved these changes
Mar 27, 2025
Chetan Patidar (chetanpatidar26)
merged commit d32f160
into
30.0.1-confluent
2 checks passed
Chetan Patidar (chetanpatidar26)
deleted the
max-interval-overrides-durationToRetain
branch
airlock-confluentinc Bot
pushed a commit
that referenced
this pull request
Apr 23, 2025
…cient (#309) * Add maxInterval to kill config and make kill tasks efficient * resolve CI
Indrajeet Garse (igarse)
added a commit
that referenced
this pull request
Apr 23, 2025
* Column adding in druid-metric * Changed to javadoc pattern * Minor fix * Checking * Fixed checkstyle * Added delayd_minutes * double * Removed redundant code * Minor fix * Test Case * Removed reflection * Fix for Class Error * Minor fix * New Interface * Minor fix * Checkstyle correction * Dependency fix * Renamed TimestampedEntity to KafkaEntity * Local testing * Dockerfile * Checkstyle correction * Modified Tests * OBSDATA-9613 Run "services" tests separately on semaphore (#312) * run "services" tests separately in semaphore * Avoid local artifacts for running tests of "services" * update command for "services" tests * Run "services" tests sequentially * pass params in MAVEN_OPTS * fix MAVEN_OPTS in "Services" * [OBSDATA-8872]Add maxInterval to kill config and make kill tasks efficient (#309) * Add maxInterval to kill config and make kill tasks efficient * resolve CI * Reduce the poll duration for CoordinatorBasedSegmentHandoffNotifierConfig from 1M to 1S (#317) * OBSDATA-9685 Add RDS root CA certs to Dockerfile (#319) * Remove logic to disable "hard rest" and "set offsets" button when supervisor is in suspended state (#321) * Modify "maxRowsInMemory"and "maxBytesInMemory" to use values from config (#323) --------- Co-authored-by: Suraj Goel <sugoel@confluent.io> Co-authored-by: Chetan Patidar <122344823+chetanpatidar26@users.noreply.github.com> Co-authored-by: Rushikesh Bankar <67940386+rbankar7@users.noreply.github.com> Co-authored-by: Sadananda Aithal <111732128+saithal-confluent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TL;DR
Kill tasks on cordinators are lagging, causing deep storage to increase rapidly and ingest handoff time spikes. This PR is to fix that.
For more description, please follow
Release note
For tips about how to write a good release note, see Release notes.
Key changed/added classes in this PR
KillUnusedSegmentsThis PR has: