Add KSQL workshop#15
Closed
Robin Moffatt (rmoff) wants to merge 2 commits intoconfluentinc:masterfrom
rmoff:ksql-workshop
Closed
Add KSQL workshop#15Robin Moffatt (rmoff) wants to merge 2 commits intoconfluentinc:masterfrom rmoff:ksql-workshop
Robin Moffatt (rmoff) wants to merge 2 commits intoconfluentinc:masterfrom
rmoff:ksql-workshop
Conversation
Member
Author
Yeva Byzek (ybyzek)
suggested changes
Jun 22, 2018
Contributor
Yeva Byzek (ybyzek)
left a comment
Yeva Byzek (ybyzek)
left a comment
There was a problem hiding this comment.
We cannot merge until it has a working start.sh. I can own doing the whole port over, that would make sense if you plan to you retire your version and use just this one moving forward?
Contributor
|
Robin Moffatt (@rmoff) : Thanks for all your hard work in making the KSQL workshop. I will get it merged in a separate PR: cancelling this PR, working on a separate branch to integrate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new folder for a docker-ised workshop for learning KSQL.
Note that it is based on the same idea as the existing
ratingsdemo, so I'm not sure if we have both, or it supersedes it?