Recent updates in Confluent Cloud have improved the reliability of queries. #11
Conversation
…eries. This negates the need for the retries that were previously used. The retry logic has been removed as a consequence.
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
| @Test | ||
| @Timeout(60) | ||
| public void createFreeShippingTable_shouldCreateTheTable() { | ||
| deleteTable(orderQualifiedForFreeShippingTableName); |
There was a problem hiding this comment.
VSCode doesn't respect the shutdown hooks that normally delete this table if you terminate the tests prematurely. This can leave things in a state where the test will fail because the table already exists.
Proactively deleting the table prior to running ensures that this doesn't happen.
| } | ||
|
|
||
| public TableResult streamOrderPlacedAfterClick(Duration withinTimePeriod) { | ||
| createOrderPlacedAfterClickTable(); |
There was a problem hiding this comment.
This doesn't need to be there, and it's not in the exercise instructions. Removing it for consistency with other similar methods.
alpinegizmo
left a comment
alpinegizmo
left a comment
There was a problem hiding this comment.
Nice to see things being simplified.
Description
Recent updates in Confluent Cloud have improved the reliability of queries.
This negates the need for the retries that were previously used. The retry logic has been removed as a consequence.
Checklist
./build.sh validate.