fix(E2E): save default user settings in test-specific tempdir#3334
Merged
Dave Shoup (shouples) merged 1 commit intomainfrom Mar 20, 2026
Merged
fix(E2E): save default user settings in test-specific tempdir#3334Dave Shoup (shouples) merged 1 commit intomainfrom
Dave Shoup (shouples) merged 1 commit intomainfrom
Conversation
… to writing directly to the user data dir
Dave Shoup (shouples)
changed the base branch from
djs/playwright-triage-skill
to
main
airlock-confluentinc
Bot
force-pushed
the
djs/fix-modal-editor
branch
from
3968f68 to
74386aa
Compare
|
Lucia Cerchie (Cerchie)
approved these changes
Mar 20, 2026
Contributor
Lucia Cerchie (Cerchie)
left a comment
Lucia Cerchie (Cerchie)
left a comment
There was a problem hiding this comment.
looks better than dealing with the clipboard!
I ran the scaffolding suite to test, I had some failures on local but I figure that had to do with the state of my docker setup. the ccloud sub-suite passed which told me that this is working
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, the behavior of the
Preferences: Open User Settings (JSON)command changed in a recent VS Code release, and it instead shows a modal editor window instead of directly displaying an editable document:This caused our E2E tests to start failing, since they would always try to navigate the UI, open the user settings.json from the command palette, and then save from the editor in order to apply VS Code settings.
This PR changes the behavior so we save the file directly to the test's (tempdir) user data directory, which VS Code watches and loads from automatically. (Bonus: this also reduces overall test time.)