cache VS Code downloads to speed up test runs#3342
Merged
Dave Shoup (shouples) merged 2 commits intomainfrom Mar 24, 2026
Merged
cache VS Code downloads to speed up test runs#3342Dave Shoup (shouples) merged 2 commits intomainfrom
Dave Shoup (shouples) merged 2 commits intomainfrom
Conversation
| [[ $(os_name) == "Darwin" ]] && $(MAKE) sem-cache-store-entry SEM_CACHE_KEY=$(PLATFORM)_$(ARCH)_playwright_cache SEM_CACHE_PATH=$(HOME)/Library/Caches/ms-playwright || true | ||
| [[ $(os_name) == "Linux" ]] && $(MAKE) sem-cache-store-entry SEM_CACHE_KEY=$(PLATFORM)_$(ARCH)_playwright_cache SEM_CACHE_PATH=$(HOME)/.cache/ms-playwright || true | ||
| # Also cache VS Code binaries downloaded by @vscode/test-electron if present | ||
| [[ -d $(CURDIR)/.vscode-test ]] && $(MAKE) sem-cache-store-entry SEM_CACHE_KEY=$(PLATFORM)_$(ARCH)_vscode_test_cache SEM_CACHE_PATH=$(CURDIR)/.vscode-test || true |
Contributor
Author
There was a problem hiding this comment.
.vscode-test/ as seen locally after running a few months' worth of tests:
There was a problem hiding this comment.
Pull request overview
Adds Semaphore CI caching for the VS Code binaries downloaded during tests (via @vscode/test-electron) to reduce repeated 150MB+ downloads and improve test reliability during upstream download issues.
Changes:
- Store
.vscode-test/in Semaphore cache when present. - Restore the
.vscode-test/cache during CI setup.
|
Noel Cothren (noeldevelops)
approved these changes
Mar 24, 2026
Member
Noel Cothren (noeldevelops)
left a comment
Noel Cothren (noeldevelops)
left a comment
There was a problem hiding this comment.
wow yes makes a ton of sense not to re-download every time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor addition to the caching to include the VS Code executable (150MB+), which will also help if we see waves of failed downloads like we did today:
