fix(E2E): paste from clipboard instead of typing fixture content into documents#3361
Merged
Dave Shoup (shouples) merged 5 commits intomainfrom Apr 8, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves E2E test stability for editor interactions by switching from per-keystroke typing (pressSequentially) to clipboard-based paste when inserting fixture content into VS Code text documents, avoiding interference from diagnostics/notifications and auto-editing behaviors.
Changes:
- Add a clipboard write helper and update
TextDocument.insertContent()to paste viaControlOrMeta+v. - Grant
"clipboard-read"/"clipboard-write"permissions once in the shared E2EbaseTestfixture and remove redundant per-test permission granting where touched. - Clarify/default editor settings comments around formatting-related behaviors in tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tests/e2e/utils/settings.ts |
Updates guidance around editor settings that can affect test content insertion. |
tests/e2e/utils/flinkStatement.ts |
Removes now-redundant clipboard permission grant in Flink statement helper flow. |
tests/e2e/utils/clipboard.ts |
Introduces writeToClipboard() and updates clipboard permission notes. |
tests/e2e/objects/editor/TextDocument.ts |
Switches document insertion to clipboard write + paste for stability. |
tests/e2e/baseTest.ts |
Centralizes clipboard permissions in the base Electron context setup. |
|
Lucia Cerchie (Cerchie)
approved these changes
Apr 8, 2026
Contributor
Lucia Cerchie (Cerchie)
left a comment
Lucia Cerchie (Cerchie)
left a comment
There was a problem hiding this comment.
There's a grammar nit, but functionally, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
We've seen an uptick in test failures when trying to write schema content to a text document in the E2E tests since they now show some IDE diagnostics and an error notification:
So instead of playing whack-a-mole with editor settings, this PR swaps the
pressSequentiallybehavior to fill editor document contents with copying the fixture body to the test clipboard and pasting directly.Latest run, happy Windows tests:
Pull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
Release notes