Keep versioned GitHub releases#1575
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1575 +/- ##
==========================================
+ Coverage 80.70% 87.39% +6.69%
==========================================
Files 65 76 +11
Lines 4794 5134 +340
==========================================
+ Hits 3869 4487 +618
+ Misses 925 647 -278
Flags with carried forward coverage won't be shown. Click here to find out more. |
simonbaird
force-pushed
the
keep-github-releases
branch
from
87aacaf to
7dd9a70
Compare
|
I'll probably merge once it goes green. |
simonbaird
force-pushed
the
keep-github-releases
branch
from
7dd9a70 to
118ce9d
Compare
|
Looks like the acceptance failure is a timeout (maybe) related to |
|
Hold up, I found this: So maybe we have a expiration date to bump. |
This makes debugging a little easier because you can see what the output value is when looking at the workflow logs in GitHub. Ref: https://issues.redhat.com/browse/EC-602
This text is visible in at https://github.com/enterprise-contract/ec-cli/releases and I think it looks better with a period at the end. (We might set a release description for the versioned releases in future, but for now we're keeping it simple.) Ref: https://issues.redhat.com/browse/EC-602
See relevant docs at https://github.com/softprops/action-gh-release?tab=readme-ov-file#-customizing It's necessary to remove the "prerelease" option since a prerelease build can't be designated as the latest. (I was hoping to prevent the rolling release from being pushed down the page every time a new release is created, but it looks like that's still happening. It seems reasonable to designate the rolling release as the latest, so let's keep this change anyhow.) Ref: https://issues.redhat.com/browse/EC-602
simonbaird
force-pushed
the
keep-github-releases
branch
from
6c62da2 to
915295d
Compare
|
Rebased on the tuf root/signed image refresh in #1576 which should get the tests passing. |
|
Acceptance test failed, not sure why. Re-running. |
|
Konflux EC check failure is a known issue. Everything else is green. Let's merge. |
2 participants
The idea is to make it easier for someone to use a known version of EC for the sake of stability.
Ref: EC-602