Publish versioned release after snapshot release#1578
Merged
simonbaird merged 1 commit intoconforma:mainfrom May 1, 2024
Merged
Publish versioned release after snapshot release#1578simonbaird merged 1 commit intoconforma:mainfrom
simonbaird merged 1 commit intoconforma:mainfrom
Conversation
There's a short window of time between removing the snapshot build and creating a new one, where the snapshot release doesn't exist. IIUC this change should make that window shorter because we're publishing the snapshot release before the versioned release instead of after. It looks like the time taken for a release publish is 6 seconds, so this potentially reduces the time we have no snapshot release available from 12 seconds down to 6 seconds, give or take. There might be a way to eliminate the 6 second gap entirely and also avoid the scenario where a broken release builds means there is no snapshot available at all, but I'll file a separate story for that and we can worry about it later. Followup patch for: Ref: https://issues.redhat.com/browse/EC-602
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1578 +/- ##
==========================================
+ Coverage 80.70% 87.39% +6.69%
==========================================
Files 65 76 +11
Lines 4794 5134 +340
==========================================
+ Hits 3869 4487 +618
+ Misses 925 647 -278
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
Author
|
Trivial change so I think I'll merge without review. |
simonbaird
added a commit
to simonbaird/conforma-cli
that referenced
this pull request
May 2, 2024
In commit 33af162 PR conforma#1578 there was an unintentional side-effect of changing which release was designated as "latest" in GitHub. Let's undo the unintentional change. Followup to a followup of... Ref: https://issues.redhat.com/browse/EC-602
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a short window of time between removing the snapshot build and creating a new one, where the snapshot release doesn't exist. IIUC this change should make that window shorter because we're publishing the snapshot release before the versioned release instead of after.
It looks like the time taken for a release publish is 6 seconds, so this potentially reduces the time we have no snapshot release available from 12 seconds down to 6 seconds, give or take.
There might be a way to eliminate the 6 second gap entirely and also avoid the scenario where a broken release builds means there is no snapshot available at all, but I'll file a separate story for that and we can worry about it later.
Followup patch for:
Ref: https://issues.redhat.com/browse/EC-602