Refactor everything relating to OCI client#1601
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1601 +/- ##
==========================================
+ Coverage 80.79% 87.25% +6.46%
==========================================
Files 65 75 +10
Lines 4738 5045 +307
==========================================
+ Hits 3828 4402 +574
+ Misses 910 643 -267
Flags with carried forward coverage won't be shown. Click here to find out more.
|
zregvart
force-pushed
the
pr/cleanup-oci-client
branch
from
41b78e3 to
83af984
Compare
simonbaird
approved these changes
May 10, 2024
simonbaird
left a comment
simonbaird
left a comment
Member
There was a problem hiding this comment.
I'm reviewing the intention more than the code changes, but lgtm afaict. The tests are green so should be good right?
lcarva
reviewed
May 13, 2024
zregvart
force-pushed
the
pr/cleanup-oci-client
branch
from
83af984 to
0412135
Compare
lcarva
approved these changes
May 14, 2024
Contributor
|
Thanks for doing this much needed re-factoring. It's beautiful 🤌 |
This refactors all codepaths to use the single OCI client abstraction and a single fake/mock in testing. Now all options provided to go-containerregistry are maintaned in the single place `internal/utils/oci/client.go`.
zregvart
force-pushed
the
pr/cleanup-oci-client
branch
from
0412135 to
0c8f7b3
Compare
Contributor
Author
|
Merging this now, if there are any followups feel free to create issues for them... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors all codepaths to use the single OCI client abstraction and a single fake/mock in testing.
Now all options provided to go-containerregistry are maintaned in the single place
internal/utils/oci/client.go.