Use go-toolset golang base image for redhat builds#1608
Merged
simonbaird merged 1 commit intoconforma:mainfrom May 10, 2024
Merged
Use go-toolset golang base image for redhat builds#1608simonbaird merged 1 commit intoconforma:mainfrom
simonbaird merged 1 commit intoconforma:mainfrom
Conversation
Use root user instead of the 'default' user from go-toolset to avoid
an error like this:
fatal: detected dubious ownership in repository at '/build'
To add an exception for this directory, call:
git config --global --add safe.directory /build
Could also have solved the problem by doing a --chown=default:root
when copying in the files.
Contributor
|
Does this leave the working user as |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1608 +/- ##
==========================================
+ Coverage 80.70% 87.39% +6.69%
==========================================
Files 65 76 +11
Lines 4794 5134 +340
==========================================
+ Hits 3869 4487 +618
+ Misses 925 647 -278
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
Author
No, because it's just the build step. In the final image we have |
Contributor
Ack. |
zregvart
approved these changes
May 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use root user instead of the 'default' user from go-toolset to avoid an error like this:
fatal: detected dubious ownership in repository at '/build'
To add an exception for this directory, call:
git config --global --add safe.directory /build
Could also have solved the problem by doing a --chown=default:root when copying in the files.
Ref: https://issues.redhat.com/browse/EC-625