Skip to content

Some minor Dockerfile delinting#1657

Merged
zregvart merged 2 commits intoconforma:mainfrom
simonbaird:small-dockerfile-delint
May 31, 2024
Merged

Some minor Dockerfile delinting#1657
zregvart merged 2 commits intoconforma:mainfrom
simonbaird:small-dockerfile-delint

Conversation

@simonbaird
Copy link
Member

@simonbaird simonbaird commented May 30, 2024

  • Add a trailing slash for multi-file copy commands
  • Indent long RUN commands with with two spaces instead of four

@simonbaird simonbaird force-pushed the small-dockerfile-delint branch from c7f1a61 to 1bdb242 Compare May 30, 2024 22:10
As directed by the nvim-treesitter dockerfile parser.
@simonbaird simonbaird force-pushed the small-dockerfile-delint branch from 1bdb242 to 1dca4a2 Compare May 30, 2024 22:11
(This is what the nvim formatter wants so I'm going with the flow.)
@simonbaird simonbaird force-pushed the small-dockerfile-delint branch from 1dca4a2 to 459b2f0 Compare May 30, 2024 22:12
@codecov
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.81%. Comparing base (4e3a778) to head (459b2f0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1657      +/-   ##
==========================================
+ Coverage   80.13%   86.81%   +6.67%     
==========================================
  Files          65       76      +11     
  Lines        4788     5128     +340     
==========================================
+ Hits         3837     4452     +615     
+ Misses        951      676     -275     
Flag Coverage Δ
acceptance 72.06% <ø> (?)
generative 80.13% <ø> (ø)
integration 80.13% <ø> (ø)
unit 80.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 41 files with indirect coverage changes

@zregvart zregvart merged commit 150e55d into conforma:main May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants