Fix duplicate package import for gcr/v1#2486
Merged
simonbaird merged 1 commit intoconforma:mainfrom Apr 23, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2486 +/- ##
=======================================
Coverage 68.27% 68.27%
=======================================
Files 101 101
Lines 8409 8409
=======================================
Hits 5741 5741
Misses 2668 2668
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
Author
|
/retest |
Member
Author
|
It's a trivial change and the CI is green, so I'll merge without further review. |
Member
Author
|
Actually I was just grepping the code, and everywhere else we use v1.Descriptor. So actually I want to make a revision to use that here also. |
simonbaird
force-pushed
the
remove-dupe-import
branch
from
2c072b6 to
51c2037
Compare
simonbaird
commented
Apr 23, 2025
| @@ -311,7 +310,7 @@ func TestEvaluatorLifecycle(t *testing.T) { | |||
| client.On("Head", mock.Anything).Return(&v1.Descriptor{MediaType: types.OCIManifestSchema1}, nil) | |||
Member
Author
There was a problem hiding this comment.
This line is the one use of v1.Descriptor that was already present.
simonbaird
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I rebased the commit from #2482, which should get the Konflux checks green, and pushed a new PR.