Skip to content

Fix silently failing acceptance test scenario#3109

Merged
st3penta merged 1 commit intoconforma:mainfrom
st3penta:fix-acceptance-case
Feb 12, 2026
Merged

Fix silently failing acceptance test scenario#3109
st3penta merged 1 commit intoconforma:mainfrom
st3penta:fix-acceptance-case

Conversation

@st3penta
Copy link
Contributor

No description provided.

@qodo-code-review
Copy link
Contributor

Review Summary by Qodo

Fix silently failing acceptance test with backtick pattern support
🐞 Bug fix 🧪 Tests

Grey Divider

Walkthroughs

Description
• Add new step definition for task logs matching with backtick syntax
• Update acceptance test to use backtick-delimited string pattern
• Fix silently failing test scenario by supporting alternative regex pattern
Diagram
flowchart LR
  A["Step Definition Registration"] -- "adds backtick pattern" --> B["New Step Handler"]
  C["Feature Test"] -- "uses backtick syntax" --> B
  B -- "enables proper matching" --> D["Test Passes"]
Loading

Grey Divider

File Changes

1. acceptance/kubernetes/kubernetes.go ✨ Enhancement +1/-0

Add backtick-delimited step definition for logs

• Added new step definition supporting backtick-delimited regex pattern
• Registers step for matching task logs with backtick syntax
• Allows flexible string matching in acceptance test scenarios

acceptance/kubernetes/kubernetes.go


2. features/task_validate_image.feature 🐞 Bug fix +1/-1

Update test to use backtick-delimited pattern

• Updated test assertion to use backtick-delimited string pattern
• Changed from quoted string to backtick syntax for log matching
• Fixes silent test failure by using correct pattern format

features/task_validate_image.feature


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@st3penta st3penta force-pushed the fix-acceptance-case branch from e7dc42d to 7840d83 Compare February 12, 2026 10:29
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
acceptance 55.48% <ø> (+<0.01%) ⬆️
generative 18.59% <ø> (ø)
integration 27.60% <ø> (ø)
unit 68.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@dheerajodha dheerajodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@st3penta st3penta merged commit 44389c3 into conforma:main Feb 12, 2026
17 checks passed
@st3penta st3penta deleted the fix-acceptance-case branch February 12, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants