Shorten some long unflat package names#1379
Merged
simonbaird merged 1 commit intoconforma:mainfrom May 5, 2025
Merged
Conversation
The files being fixed here were using the old convention of nested namespace package names, which we used to do, but stopped doing in conforma#1198 . The symptom is a little unexpected -- some missing description/solution text in a violation report due to how the the metadata lookup is done by the cli. This could actually could be a separate bug, out of scope in this PR, but possibly in scope for https://issues.redhat.com/browse/EC-945 which I am also looking at currently. Anyway, this change should be enough to fix EC-1233. Note: The collection.rhtap_multi_ci change might not have any impact, but I'll change it anyhow so it's consistent with the others. Ref: https://issues.redhat.com/browse/EC-1233
st3penta
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The files being fixed here were using the old convention of nested namespace package names, which we used to do, but stopped doing in #1198 .
The symptom is a little unexpected -- some missing description/solution text in a violation report due to how the the metadata lookup is done by the cli. This could actually could be a separate bug, out of scope in this PR, but possibly in scope for https://issues.redhat.com/browse/EC-945 which I am also looking at currently.
Anyway, this change should be enough to fix EC-1233.
Note: The collection.rhtap_multi_ci change might not have any impact, but I'll change it anyhow so it's consistent with the others.
Ref: https://issues.redhat.com/browse/EC-1233