feat(CLOUDDST-29067): Add OLM allowed resource kinds policy#1506
Merged
simonbaird merged 1 commit intoconforma:mainfrom Sep 2, 2025
Merged
feat(CLOUDDST-29067): Add OLM allowed resource kinds policy#1506simonbaird merged 1 commit intoconforma:mainfrom
simonbaird merged 1 commit intoconforma:mainfrom
Conversation
asergienk
force-pushed
the
allowed_resource_kinds_check
branch
2 times, most recently
from
d8fca17 to
40ff19a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
asergienk
force-pushed
the
allowed_resource_kinds_check
branch
from
40ff19a to
d270a8d
Compare
nmars
reviewed
Aug 28, 2025
nmars
reviewed
Aug 28, 2025
yashvardhannanavati
approved these changes
Aug 29, 2025
st3penta
reviewed
Aug 29, 2025
simonbaird
approved these changes
Aug 29, 2025
Member
simonbaird
left a comment
simonbaird
left a comment
There was a problem hiding this comment.
Nice PR!
Approved, but I think you should remove the redundant result := true as suggested.
asergienk
force-pushed
the
allowed_resource_kinds_check
branch
from
d270a8d to
1c91c50
Compare
asergienk
force-pushed
the
allowed_resource_kinds_check
branch
from
1c91c50 to
9e96e87
Compare
nmars
approved these changes
Aug 29, 2025
Author
|
@simonbaird could you please merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Conforma Policy to validate OLM bundle manifests against the allowed resource kinds. The initial request was to check for NetworkPolicy manifests and fail if they are present. However, during refinement, it was decided to broaden the scope to verify all manifests, not just NetworkPolicy.
There is no
effective_ondate set for this policy, as the work is urgent and should immediately block bundle releases containing NetworkPolicy manifests.