Sequence reset gap fill reverse verify logic #784
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vyourtchenko-connamara
force-pushed
the
SequenceReset_GapFill_Reverse_Verify_Logic
branch
6 times, most recently
from
154f39d to
f281628
Compare
gbirchmeier
force-pushed
the
SequenceReset_GapFill_Reverse_Verify_Logic
branch
from
ff0c1b0 to
5b5440c
Compare
…msgs that reset the sequnece number with the same msgseqnum that caused the initial resendrequest
…DupFlag=Y a check on missing OrigSendingTime tag never runs
…pFlag=Y yet do not trigger DoTargetTooLow thus not checking for OrigSendingTime under the new logic
gbirchmeier
force-pushed
the
SequenceReset_GapFill_Reverse_Verify_Logic
branch
from
5b5440c to
cfce33c
Compare
gbirchmeier
added a commit
to gbirchmeier/quickfixn
that referenced
this pull request
Mar 27, 2025
gbirchmeier
added a commit
to gbirchmeier/quickfixn
that referenced
this pull request
Apr 9, 2025
PR connamara#784 which is intended to fix issue connamara#309
gbirchmeier
added a commit
to gbirchmeier/quickfixn
that referenced
this pull request
Apr 11, 2025
PR connamara#784 which is intended to fix issue connamara#309
Member
|
Closing because #957 supercedes it |
gbirchmeier
added a commit
to gbirchmeier/quickfixn
that referenced
this pull request
May 19, 2025
PR connamara#784 which is intended to fix issue connamara#309
gbirchmeier
added a commit
to gbirchmeier/quickfixn
that referenced
this pull request
Oct 14, 2025
PR connamara#784 which is intended to fix issue connamara#309
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current logic in Session.NextSequenceReset causes SequenceReset messages with GapFill=Y to be ignored during message replay.
This change reverses the logic to fix the issue discussed here:
#309 (comment)