Update net.i2p.crypto.eddsa to 0.2.0#35
Merged
kruton merged 3 commits intoconnectbot:masterfrom Apr 6, 2018
Merged
Conversation
|
Could this and #34 be merged? The CI-failures seem related to old Java version and not indicative of any real issues. |
as dependency of net.vrallev.ecc.ecc-25519-java
|
I have two questions:
|
Contributor
Author
|
kruton
reviewed
Apr 6, 2018
|
|
||
| return new EdDSAPublicKey(new EdDSAPublicKeySpec(keyBytes, | ||
| EdDSANamedCurveTable.getByName(EdDSANamedCurveTable.CURVE_ED25519_SHA512))); | ||
| return new EdDSAPublicKey(new EdDSAPublicKeySpec(keyBytes, EdDSANamedCurveTable.getByName(ED25519_CURVE_NAME) )); |
Member
There was a problem hiding this comment.
nit: extra space between closing parathenses.
|
I couldn't find a |
|
@kruton I was wondering about the CLA. Is it new? Can you put a LICENSE file in the sshlib repo to clarify the status of this library? Assuming from some headers, it should be Apache v2. |
Member
|
Ah, I should fix any headers... probably IDE auto-inserted. It's 3-Clause BSD originally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update net.i2p.crypto.eddsa to 0.2.0 to allow loading keys with the new OIDs from draft-ietf-curdle-pkix.
This overrides dependency of net.vrallev.ecc.ecc-25519-java on eddsa-0.1.0.
net.vrallev.ecc.ecc-25519-java is probably not going to get updated anytime soon, since it has been deprecated.