Feature/improve template body class#166
Merged
elseloop merged 3 commits intodevelopmentfrom Aug 20, 2015
Merged
Conversation
Contributor
|
The question came up in an offline conversation: what prompted this? When you're running PHP in dev mode (verbose errors) and have not set $bodyClass, the existing code will issue a PHP error inline into the class attribute. While most browsers will handle this without error, it still results in wildly invalid markup. |
Because fatal errors are bad, @stoff. They're just bad. 💩
elseloop
added a commit
that referenced
this pull request
Aug 20, 2015
…dy_class Improves template body class 
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(From #164, originally opened by @stoff)
Minor improvement to add some logic between echoing a class in the head.php include and setting the body class in the template file.
getBodyClass tests isset on $bodyClass. if set, it echos the entire class attribute, concatenated with the body class.